Style more consistent, replace capitalization with camel case
This commit is contained in:
@ -5,7 +5,7 @@ module Variable = struct
|
||||
let pp (ppf: out_channel) (v: t) : unit =
|
||||
Printf.fprintf ppf "%s" v
|
||||
|
||||
let pplist (ppf: out_channel) (vv: t list) : unit =
|
||||
let pp_list (ppf: out_channel) (vv: t list) : unit =
|
||||
List.iter (Printf.fprintf ppf "%s, ") vv
|
||||
|
||||
let compare a b =
|
||||
@ -19,7 +19,7 @@ module DVCeltSet = Set.Make(Variable)
|
||||
|
||||
|
||||
let variables (instr : DVCfg.elt) : DVCfg.internal list =
|
||||
let helper (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
let aux (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
match instr with
|
||||
| Nop ->
|
||||
acc
|
||||
@ -37,7 +37,7 @@ let variables (instr : DVCfg.elt) : DVCfg.internal list =
|
||||
DVCeltSet.add r3.index acc
|
||||
in
|
||||
|
||||
helper DVCeltSet.empty instr |> DVCeltSet.to_list
|
||||
aux DVCeltSet.empty instr |> DVCeltSet.to_list
|
||||
|
||||
let variables_all (instructions : DVCfg.elt list) : DVCfg.internal list =
|
||||
List.fold_left (fun (acc: DVCeltSet.t) (instr: DVCfg.elt) ->
|
||||
@ -45,7 +45,7 @@ let variables_all (instructions : DVCfg.elt list) : DVCfg.internal list =
|
||||
) DVCeltSet.empty instructions |> DVCeltSet.to_list
|
||||
|
||||
let variables_used (instr : DVCfg.elt) : DVCfg.internal list =
|
||||
let helper (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
let aux (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
match instr with
|
||||
| Nop
|
||||
| LoadI (_, _) ->
|
||||
@ -60,7 +60,7 @@ let variables_used (instr : DVCfg.elt) : DVCfg.internal list =
|
||||
DVCeltSet.add r1.index acc
|
||||
in
|
||||
|
||||
helper DVCeltSet.empty instr |> DVCeltSet.to_list
|
||||
aux DVCeltSet.empty instr |> DVCeltSet.to_list
|
||||
|
||||
let variables_used_all (instructions : DVCfg.elt list) : DVCfg.internal list =
|
||||
List.fold_left (fun (acc: DVCeltSet.t) (instr: DVCfg.elt) ->
|
||||
@ -69,7 +69,7 @@ let variables_used_all (instructions : DVCfg.elt list) : DVCfg.internal list =
|
||||
|
||||
|
||||
let variables_defined (instructions : DVCfg.elt) : DVCfg.internal list =
|
||||
let helper (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
let aux (acc: DVCeltSet.t) (instr: DVCfg.elt) =
|
||||
match instr with
|
||||
| Nop
|
||||
| Store (_, _) -> acc
|
||||
@ -81,116 +81,118 @@ let variables_defined (instructions : DVCfg.elt) : DVCfg.internal list =
|
||||
DVCeltSet.add r3.index acc
|
||||
in
|
||||
|
||||
helper DVCeltSet.empty instructions |> DVCeltSet.to_list
|
||||
aux DVCeltSet.empty instructions |> DVCeltSet.to_list
|
||||
|
||||
|
||||
(* init function, assign the bottom to everything *)
|
||||
let _init_bottom : (DVCfg.elt list -> DVCfg.internalnode) =
|
||||
(fun l -> {internalin = [];
|
||||
internalout = [];
|
||||
internalbetween = (List.init (List.length l) (fun _ -> ([], [])))})
|
||||
let _init_bottom : (DVCfg.elt list -> DVCfg.internal_node) =
|
||||
(fun l -> {internal_in = [];
|
||||
internal_out = [];
|
||||
internal_between = (List.init (List.length l) (fun _ -> ([], [])))}
|
||||
)
|
||||
|
||||
(* init function, assign the top to everything *)
|
||||
let init_top (all_variables) : (DVCfg.elt list -> DVCfg.internalnode) =
|
||||
(fun l -> {internalin = all_variables;
|
||||
internalout = all_variables;
|
||||
internalbetween = (List.init (List.length l)
|
||||
let init_top (all_variables) : (DVCfg.elt list -> DVCfg.internal_node) =
|
||||
(fun l -> {internal_in = all_variables;
|
||||
internal_out = all_variables;
|
||||
internal_between = (List.init (List.length l)
|
||||
(fun _ -> (all_variables, all_variables)))})
|
||||
|
||||
|
||||
let lub (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internalnode =
|
||||
let previnternalvar = Cfg.NodeMap.find node t.internalvar in
|
||||
let lub (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internal_node =
|
||||
let prev_internal_var = Cfg.NodeMap.find node t.internal_var in
|
||||
let code = match Cfg.NodeMap.find_opt node t.t.content with
|
||||
None -> []
|
||||
| Some c -> c
|
||||
in
|
||||
|
||||
let newinternalbetween = (
|
||||
let new_internal_between = (
|
||||
List.map
|
||||
(fun (code, (i, _o)) ->
|
||||
(i, Utility.unique_union i (variables_defined code)))
|
||||
(List.combine code previnternalvar.internalbetween)
|
||||
(List.combine code prev_internal_var.internal_between)
|
||||
) in
|
||||
|
||||
let newinternalout =
|
||||
match newinternalbetween with
|
||||
let new_internal_out =
|
||||
match new_internal_between with
|
||||
| [] ->
|
||||
previnternalvar.internalin
|
||||
prev_internal_var.internal_in
|
||||
| _ ->
|
||||
let _, newinternalout = (Utility.last_list newinternalbetween) in
|
||||
let _, newinternalout = (Utility.last_list new_internal_between) in
|
||||
newinternalout
|
||||
in
|
||||
|
||||
{ previnternalvar with
|
||||
internalbetween = newinternalbetween;
|
||||
internalout = newinternalout }
|
||||
{ prev_internal_var with
|
||||
internal_between = new_internal_between;
|
||||
internal_out = new_internal_out }
|
||||
|
||||
let lucf (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internalnode =
|
||||
let previnternalvar = Cfg.NodeMap.find node t.internalvar in
|
||||
let lucf (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internal_node =
|
||||
let prev_internal_var = Cfg.NodeMap.find node t.internal_var in
|
||||
|
||||
if Option.equal (=) (Some node) t.t.initial then
|
||||
(* if L is initial set dvin to the "in" register *)
|
||||
let newinternalin = (
|
||||
match t.t.inputOutputVar with
|
||||
let new_internal_in = (
|
||||
match t.t.input_output_var with
|
||||
Some (i, _) -> [i]
|
||||
| None -> []
|
||||
) in
|
||||
|
||||
let newinternalbetween = ( (* set the dvin of each to the previous dvout *)
|
||||
match previnternalvar.internalbetween with
|
||||
let new_internal_between = (
|
||||
(* set the dvin of each to the previous dvout *)
|
||||
match prev_internal_var.internal_between with
|
||||
[] -> []
|
||||
| [(_i, o)] -> [(newinternalin, o)]
|
||||
| [(_i, o)] -> [(new_internal_in, o)]
|
||||
| (_i, o) :: btwrest ->
|
||||
(newinternalin, o) :: (
|
||||
(new_internal_in, o) :: (
|
||||
List.map (fun ((_i, o), (_previ, prevo)) -> (prevo, o))
|
||||
(Utility.combine_twice btwrest previnternalvar.internalbetween)
|
||||
(Utility.combine_twice btwrest prev_internal_var.internal_between)
|
||||
)
|
||||
) in
|
||||
{ previnternalvar with
|
||||
internalin = newinternalin;
|
||||
internalbetween = newinternalbetween }
|
||||
{ prev_internal_var with
|
||||
internal_in = new_internal_in;
|
||||
internal_between = new_internal_between }
|
||||
else
|
||||
(* if L is not initial set dvin to the intersection of the previous node's
|
||||
dvouts *)
|
||||
let prevnodes = Cfg.NodeMap.find node t.t.reverseEdges in
|
||||
let newinternalin = (
|
||||
match prevnodes with
|
||||
let prev_nodes = Cfg.NodeMap.find node t.t.reverse_edges in
|
||||
let new_internal_in = (
|
||||
match prev_nodes with
|
||||
| [] ->
|
||||
[]
|
||||
| [prevnode] ->
|
||||
(Cfg.NodeMap.find prevnode t.internalvar).internalout
|
||||
(Cfg.NodeMap.find prevnode t.internal_var).internal_out
|
||||
| [prevnode1; prevnode2] ->
|
||||
Utility.unique_intersection
|
||||
(Cfg.NodeMap.find prevnode1 t.internalvar).internalout
|
||||
(Cfg.NodeMap.find prevnode2 t.internalvar).internalout
|
||||
(Cfg.NodeMap.find prevnode1 t.internal_var).internal_out
|
||||
(Cfg.NodeMap.find prevnode2 t.internal_var).internal_out
|
||||
| prevnode :: restnodes ->
|
||||
List.fold_left (* intersection of all previous nodes' dvout *)
|
||||
(fun acc prevnode ->
|
||||
Utility.unique_intersection
|
||||
acc
|
||||
(Cfg.NodeMap.find prevnode t.internalvar).internalout)
|
||||
(Cfg.NodeMap.find prevnode t.internalvar).internalout
|
||||
(Cfg.NodeMap.find prevnode t.internal_var).internal_out)
|
||||
(Cfg.NodeMap.find prevnode t.internal_var).internal_out
|
||||
restnodes
|
||||
) in
|
||||
|
||||
let newinternalbetween =
|
||||
match previnternalvar.internalbetween with
|
||||
let new_internal_between =
|
||||
match prev_internal_var.internal_between with
|
||||
[] -> []
|
||||
| [(_i, o)] -> [(newinternalin, o)]
|
||||
| [(_i, o)] -> [(new_internal_in, o)]
|
||||
| (_i, o) :: btwrest ->
|
||||
(newinternalin, o) :: (
|
||||
(new_internal_in, o) :: (
|
||||
List.map (fun ((_i, o), (_previ, prevo)) -> (prevo, o))
|
||||
(Utility.combine_twice btwrest previnternalvar.internalbetween)
|
||||
(Utility.combine_twice btwrest prev_internal_var.internal_between)
|
||||
)
|
||||
in
|
||||
{ previnternalvar with
|
||||
internalin = newinternalin;
|
||||
internalbetween = newinternalbetween }
|
||||
{ prev_internal_var with
|
||||
internal_in = new_internal_in;
|
||||
internal_between = new_internal_between }
|
||||
|
||||
|
||||
let update (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internalnode =
|
||||
let update (t: DVCfg.t) (node: Cfg.Node.t) : DVCfg.internal_node =
|
||||
let newt =
|
||||
{t with internalvar = (Cfg.NodeMap.add node (lucf t node) t.internalvar)}
|
||||
{t with internal_var = (Cfg.NodeMap.add node (lucf t node) t.internal_var)}
|
||||
in
|
||||
lub newt node
|
||||
|
||||
@ -204,7 +206,7 @@ let compute_defined_variables (cfg: RISCCfg.t) : DVCfg.t =
|
||||
(Cfg.NodeMap.to_list cfg.content)
|
||||
in
|
||||
let all_variables =
|
||||
match cfg.inputOutputVar with
|
||||
match cfg.input_output_var with
|
||||
| None -> all_variables
|
||||
| Some (i, o) -> Utility.unique_union all_variables [i;o]
|
||||
in
|
||||
@ -215,18 +217,18 @@ let compute_defined_variables (cfg: RISCCfg.t) : DVCfg.t =
|
||||
|
||||
let check_undefined_variables (dvcfg: DVCfg.t) : Variable.t list option =
|
||||
(* returns all undefined variables previously computed *)
|
||||
let helper (node: Cfg.Node.t) (dvcfg: DVCfg.t) : Variable.t list option =
|
||||
let aux (node: Cfg.Node.t) (dvcfg: DVCfg.t) : Variable.t list option =
|
||||
let code = match Cfg.NodeMap.find_opt node dvcfg.t.content with
|
||||
None -> []
|
||||
| Some c -> c
|
||||
in
|
||||
let internalvar = Cfg.NodeMap.find node dvcfg.internalvar in
|
||||
let internal_var = Cfg.NodeMap.find node dvcfg.internal_var in
|
||||
let vua = variables_used_all code in
|
||||
|
||||
let outvar =
|
||||
match (Option.equal (=) (Some node) dvcfg.t.terminal,
|
||||
dvcfg.t.inputOutputVar,
|
||||
internalvar.internalout) with
|
||||
dvcfg.t.input_output_var,
|
||||
internal_var.internal_out) with
|
||||
| (true, Some (_, outvar), vout) ->
|
||||
if List.mem outvar vout
|
||||
then None
|
||||
@ -235,18 +237,18 @@ let check_undefined_variables (dvcfg: DVCfg.t) : Variable.t list option =
|
||||
None
|
||||
in
|
||||
|
||||
if Utility.inclusion vua (internalvar.internalin) then
|
||||
if Utility.inclusion vua (internal_var.internal_in) then
|
||||
match outvar with None -> None
|
||||
| Some outvar -> Some [outvar]
|
||||
else
|
||||
(* the variable might be defined inside the block, so check all vin and
|
||||
return true only if all variables are properly defined *)
|
||||
let vuabetween = List.map variables_used code in
|
||||
let vua_between = List.map variables_used code in
|
||||
let undef_vars = List.fold_left
|
||||
(fun acc (codevars, (vin, _vout)) ->
|
||||
(Utility.subtraction codevars vin) @ acc)
|
||||
[]
|
||||
(List.combine vuabetween internalvar.internalbetween)
|
||||
(List.combine vua_between internal_var.internal_between)
|
||||
in
|
||||
match outvar, undef_vars with
|
||||
None, [] -> None
|
||||
@ -255,7 +257,7 @@ let check_undefined_variables (dvcfg: DVCfg.t) : Variable.t list option =
|
||||
| Some outvar, undef_vars -> Some (outvar :: undef_vars)
|
||||
in
|
||||
Cfg.NodeSet.fold (fun node acc ->
|
||||
match acc, (helper node dvcfg) with
|
||||
match acc, (aux node dvcfg) with
|
||||
None, None -> None
|
||||
| None, Some x -> Some x
|
||||
| Some acc, None -> Some acc
|
||||
|
||||
Reference in New Issue
Block a user